Fix audio events in explore section (#15286)

* Fix audio events in explore section Make sure that audio events are listed in the explore section * Update audio.py * Hide other submit options Only allow submits for objects only
blakeblackshear · Dec 1, 2024 · 5802a66 · 5802a66
1 parent 71e8f75
commit 5802a66
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 5 deletions.
diff --git a/docs/static/frigate-api.yaml b/docs/static/frigate-api.yaml
@@ -3225,7 +3225,7 @@ components:
           title: Sub Label
         score:
           anyOf:
-            - type: integer
+            - type: number
             - type: 'null'
           title: Score
           default: 0
@@ -3264,7 +3264,7 @@ components:
       properties:
         end_time:
           anyOf:
-            - type: integer
+            - type: number
             - type: 'null'
           title: End Time
       type: object

diff --git a/frigate/api/defs/events_body.py b/frigate/api/defs/events_body.py
@@ -17,14 +17,14 @@ class EventsDescriptionBody(BaseModel):
 class EventsCreateBody(BaseModel):
     source_type: Optional[str] = "api"
     sub_label: Optional[str] = None
-    score: Optional[int] = 0
+    score: Optional[float] = 0
     duration: Optional[int] = 30
     include_recording: Optional[bool] = True
     draw: Optional[dict] = {}
 
 
 class EventsEndBody(BaseModel):
-    end_time: Optional[int] = None
+    end_time: Optional[float] = None
 
 
 class SubmitPlusBody(BaseModel):

diff --git a/frigate/events/audio.py b/frigate/events/audio.py
@@ -216,6 +216,10 @@ def handle_detection(self, label: str, score: float) -> None:
                     "label": label,
                     "last_detection": datetime.datetime.now().timestamp(),
                 }
+            else:
+                self.logger.warning(
+                    f"Failed to create audio event with status code {resp.status_code}"
+                )
 
     def expire_detections(self) -> None:
         now = datetime.datetime.now().timestamp()

diff --git a/frigate/events/external.py b/frigate/events/external.py
@@ -108,6 +108,7 @@ def finish_manual_event(self, event_id: str, end_time: float) -> None:
                 EventTypeEnum.api,
                 EventStateEnum.end,
                 None,
+                "",
                 {"id": event_id, "end_time": end_time},
             )
         )

diff --git a/web/src/components/menu/SearchResultActions.tsx b/web/src/components/menu/SearchResultActions.tsx
@@ -128,6 +128,7 @@ export default function SearchResultActions({
         config?.plus?.enabled &&
         searchResult.has_snapshot &&
         searchResult.end_time &&
+        searchResult.data.type == "object" &&
         !searchResult.plus_id && (
           <MenuItem aria-label="Submit to Frigate Plus" onClick={showSnapshot}>
             <FrigatePlusIcon className="mr-2 size-4 cursor-pointer text-primary" />
@@ -197,6 +198,7 @@ export default function SearchResultActions({
             config?.plus?.enabled &&
             searchResult.has_snapshot &&
             searchResult.end_time &&
+            searchResult.data.type == "object" &&
             !searchResult.plus_id && (
               <Tooltip>
                 <TooltipTrigger>

diff --git a/web/src/components/overlay/detail/ReviewDetailDialog.tsx b/web/src/components/overlay/detail/ReviewDetailDialog.tsx
@@ -379,6 +379,7 @@ function EventItem({
 
               {event.has_snapshot &&
                 event.plus_id == undefined &&
+                event.data.type == "object" &&
                 config?.plus.enabled && (
                   <Tooltip>
                     <TooltipTrigger>

diff --git a/web/src/components/overlay/detail/SearchDetailDialog.tsx b/web/src/components/overlay/detail/SearchDetailDialog.tsx
@@ -626,7 +626,7 @@ export function ObjectSnapshotTab({
                 </div>
               )}
             </TransformComponent>
-            {search.plus_id !== "not_enabled" && search.end_time && (
+            {search.data.type == "object" && search.plus_id !== "not_enabled" && search.end_time && (
               <Card className="p-1 text-sm md:p-2">
                 <CardContent className="flex flex-col items-center justify-between gap-3 p-2 md:flex-row">
                   <div className={cn("flex flex-col space-y-3")}>
-Original file line number
+Diff line change
@@ Expand Up @@
                     EventTypeEnum.api,
                     EventStateEnum.end,
                     None,
+                    "",
                     {"id": event_id, "end_time": end_time},
                 )
             )
@@ Expand Down @@