Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated frontend_stream_type overwrite #785

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Nov 26, 2024

Fixes #798

@felipecrs felipecrs force-pushed the prepare-for-2024.12 branch 6 times, most recently from e681eb7 to bd6c399 Compare November 27, 2024 22:48
@felipecrs felipecrs changed the title Prepare for Home Assistant 2024.12 Remove workaround for bug fixed in Home Assistant 2024.12 Nov 27, 2024
@felipecrs felipecrs force-pushed the prepare-for-2024.12 branch 4 times, most recently from ee0581c to 8264b1b Compare December 4, 2024 19:53
@felipecrs felipecrs force-pushed the prepare-for-2024.12 branch from 8264b1b to e91fc4d Compare December 4, 2024 19:55
@felipecrs felipecrs changed the title Remove workaround for bug fixed in Home Assistant 2024.12 Fix deprecated frontend_stream_type overwrite Dec 4, 2024
@felipecrs felipecrs marked this pull request as ready for review December 4, 2024 19:56
@felipecrs felipecrs marked this pull request as draft December 4, 2024 19:56
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a87ed86) to head (a95d327).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #785   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2083      2077    -6     
=========================================
- Hits          2083      2077    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipecrs felipecrs closed this Dec 5, 2024
@felipecrs felipecrs reopened this Dec 5, 2024
@felipecrs felipecrs marked this pull request as ready for review December 5, 2024 16:14
@felipecrs
Copy link
Contributor Author

felipecrs commented Dec 5, 2024

@dermotduffy, @NickM-27, this is ready to go btw.

Considering the previous integration version already required HA 2024.11, and HA 2024.11 is doomed anyway because of the frontend bug, I believe we should not be afraid of releasing a new version with this "fix".

@dermotduffy dermotduffy added the bug Something isn't working label Dec 6, 2024
@dermotduffy dermotduffy merged commit b949761 into blakeblackshear:master Dec 6, 2024
10 checks passed
@dermotduffy
Copy link
Collaborator

Thanks @felipecrs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected that custom integration 'frigate' is overwriting the 'frontend_stream_type'
3 participants