Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle cameras that are not streaming #782

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Nov 26, 2024

This partially reverts #776, but also handles the case when birdseye would not be streaming (important to remember that birdseye doesn't even have streaming enabled by default) (EDIT: this was a mistake, birdseye entity is not even added if birdseye.restream is not enabled).

The rationale is: indeed, it is possible to have cameras in Frigate without streaming capabilities (i.e. if you don't have the camera set in your go2rtc).

@felipecrs felipecrs marked this pull request as draft November 26, 2024 20:39
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (85cfdd0) to head (85e5d8a).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #782   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2048      2050    +2     
=========================================
+ Hits          2048      2050    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipecrs felipecrs marked this pull request as ready for review November 26, 2024 21:13
@dermotduffy dermotduffy added the bug Something isn't working label Nov 27, 2024
@dermotduffy dermotduffy merged commit e4fa487 into blakeblackshear:master Nov 27, 2024
10 checks passed
@dermotduffy
Copy link
Collaborator

Thanks @felipecrs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants