Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer for latest Frigate and Home Assistant #720

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Sep 12, 2024

Including:

  • The Big Buck Bunny RTSP link is no longer working
  • Compatibility with latest Frigate
  • Fixes for deprecated stuff with latest Home Assistant
  • Upgrade devcontainer image
  • Remove unnecessary configuration from devcontainer.json
  • Fix Frigate schema json path

@felipecrs felipecrs marked this pull request as draft September 12, 2024 15:55
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e556147) to head (74ed5e6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #720   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2123      2123           
=========================================
  Hits          2123      2123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipecrs
Copy link
Contributor Author

I tried to upgrade Python to 3.12 but then pip install fails with:

[INFO] Installing environment for https://github.com/psf/black.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      
      Cargo, the Rust package manager, is not installed or is not on PATH.
      This package requires Rust and Cargo to compile extensions. Install it through
      the system's package manager or via https://rustup.rs/
      
      Checking for Rust toolchain....
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

Which is weird. I wonder why it would fail for Python 3.12 but not Python 3.10.

We can do it in a separate PR though.

@felipecrs felipecrs marked this pull request as ready for review September 12, 2024 16:02
@dermotduffy dermotduffy added the testing Testing label Sep 13, 2024
@dermotduffy dermotduffy merged commit 070fbf2 into blakeblackshear:master Sep 13, 2024
6 checks passed
@dermotduffy
Copy link
Collaborator

Thanks @felipecrs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants