-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media browser errors when used with Frigate 0.12 #618
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 2017 2017
=========================================
Hits 2017 2017 ☔ View full report in Codecov by Sentry. |
Planning a new build from |
I figured it would be good to get it out soon, so master made sense |
I'm currently on frigate 0.13.2 and frigate-hass-integration 5.0.1 and I still have these media browser errors for clips and snapshots. By downgrading the frigate-hass-integration to 5.0.0 this is resolved. |
the error definitely won't be the same given the way that the code changed. It is all using safe access |
Below you can find the error for frigate 0.13.2 in combination with frigate-hass-integration 5.0.1: `Logger: homeassistant.components.websocket_api.http.connection [547275896384] Error handling message: Unknown error (unknown_error) Matthias Cauwelier from 157.97.122.59 (Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36) |
It's not the same exactly, we can see here that the new code is having this issue because somehow top score doesn't exist in either place which is a separate issue and potentially a backend issue. It would be good to know what the metadata is for this event that is causing the error. |
I'm using 'manually' triggered event (https://docs.frigate.video/integrations/api/#post-apieventscamera_namelabelcreate) instead of an event triggered by a motion or an object detection. perhaps this is the reason why there is no top_score. If you need more info or metadata, could you explain what exactly and where to extract it? |
fixes #600