Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose camera PTZ information over websocket #556

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

dermotduffy
Copy link
Collaborator

@dermotduffy dermotduffy added the enhancement New feature or request label Oct 17, 2023
@dermotduffy
Copy link
Collaborator Author

@NickM-27 Would appreciate your thoughts on this, in general, but specifically:

  • This is relying on the ptz/info API call that I randomly found :-) Let me know if this is not going to stick around!
  • I am making the choice to expose this over websocket, even though the API call is over raw http. In general, unless we think something will be used by lots of people (i.e. not this!), I think it's better to "pollute" the websocket space than the "HTTP View" space, which would expose the endpoint more publicly.

PS: Build failure seems to be something unrelated, saw this in another PR, will investigate separately.

@NickM-27
Copy link
Collaborator

  1. That'll be sticking around, it is used not only in the frigate webui but also for ptz auto tracking
  2. I don't see any issues with that 👍

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a31922f) 100.00% compared to head (b3c9cde) 100.00%.
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1963      1978   +15     
=========================================
+ Hits          1963      1978   +15     
Files Coverage Δ
custom_components/frigate/api.py 100.00% <100.00%> (ø)
custom_components/frigate/ws_api.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dermotduffy dermotduffy merged commit 5eadfff into blakeblackshear:dev Oct 18, 2023
6 checks passed
@dermotduffy dermotduffy deleted the ptz-ws branch October 18, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants