Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Sensors for audio detections #516

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

NickM-27
Copy link
Collaborator

No description provided.

@NickM-27 NickM-27 marked this pull request as draft July 14, 2023 14:15
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #516 (96f912b) into dev (484f853) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev      #516   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1889      1929   +40     
=========================================
+ Hits          1889      1929   +40     
Files Changed Coverage Δ
custom_components/frigate/__init__.py 100.00% <100.00%> (ø)
custom_components/frigate/binary_sensor.py 100.00% <100.00%> (ø)
custom_components/frigate/const.py 100.00% <100.00%> (ø)
custom_components/frigate/icons.py 100.00% <100.00%> (ø)

@NickM-27 NickM-27 marked this pull request as ready for review July 24, 2023 22:36
@NickM-27
Copy link
Collaborator Author

@dermotduffy This is ready for review

@dermotduffy dermotduffy added the enhancement New feature or request label Jul 25, 2023
@dermotduffy
Copy link
Collaborator

Looking great @NickM-27 . One comment on naming order for entities, since they are long-lasting names.

@dermotduffy dermotduffy merged commit 8f26352 into blakeblackshear:dev Jul 25, 2023
@dermotduffy
Copy link
Collaborator

Thanks @NickM-27 !

@NickM-27 NickM-27 deleted the audio-sensors branch August 13, 2023 02:07
@DrSpaldo
Copy link

DrSpaldo commented Sep 2, 2023

I am not sure if anyone else is getting the same issue, but, my sensors are not returning to 'clear' after having detections of speech...

@NickM-27
Copy link
Collaborator Author

NickM-27 commented Sep 2, 2023

It's working as expected for me, recommend checking the frigate logs and maybe MQTT explorer

image

(Assuming that the event has stopped in the frigate web ui)

@DrSpaldo
Copy link

DrSpaldo commented Sep 2, 2023

Yes, the event has stopped in the Frigate UI and it just continues in HA. For example, lets use 'backdoor'

2023-09-02 screenshot (1)
2023-09-02 screenshot
2023-09-02 screenshot (2)

The event only lasted 30 seconds at 19:44. Ended at that time in Frigate, but has not made it through to MQTT/HA?

@NickM-27
Copy link
Collaborator Author

NickM-27 commented Sep 2, 2023

That doesn't really add up, the MQTT message OFF is sent before the event is ended. There are no errors in the logs?

@DrSpaldo
Copy link

DrSpaldo commented Sep 2, 2023

That doesn't really add up, the MQTT message OFF is sent before the event is ended. There are no errors in the logs?

Nope, nothing in the Frigate logs since boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants