Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changed mqtt.async_publish in HA core 2021.12 #166

Closed
wants to merge 3 commits into from

Conversation

emontnemery
Copy link

@emontnemery emontnemery commented Oct 28, 2021

mqtt.async_publish is a couroutine in HA core 2021.12: home-assistant/core#58441

This PR bumps the minimum version of HA to 2021.12.0.

If this is not wanted, something like this would work to keep compatibility with old versions of Home Assistant Core:

hass.async_add_job(async_publish, hass, topic, payload)

@dermotduffy dermotduffy self-assigned this Oct 30, 2021
@dermotduffy
Copy link
Collaborator

Thank you @emontnemery , sincerely appreciate the proactive outreach to custom integrations. Looks like 1 failing test, now that I've approved the workflow run.

@emontnemery
Copy link
Author

The test is failing because CI is not testing against HA 2021.12 (which doesn't yet exist).
mqtt.async_publish is not a coroutine in any released version, it's only on the dev branch so far.

@dermotduffy
Copy link
Collaborator

Included as part of #183 . Thank you again for the advanced warning!

@dermotduffy dermotduffy closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants