Add cache command #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix styling wip Fix styling Build cache file Add getCachedIconsPath method Fix docblock Refactor Remove prepareSets() Add test Fix styling Remove method Update test Fix styling Revert "Fix styling" This reverts commit e0101e7. Fix style Delete .gitkeep Exclude tests/fixtures dir
Closed
|
@mvdnbrk anything you need help with to finalize this? |
|
Sorry didn't have much time to dive further into this. I think we need some more modifications, particularly how icon sets are registered in the package. Can you take a look @driesvints and share your thoughts? |
|
I'n sorry I didn't get to this. Last weeks have been extra busy for me. I'm hoping to get to these prs/issues soon. |
|
Take a breath @driesvints no worries. If there is anything I can do to help you keep things going please let me know. Would be glad to help 😄 |
|
Hi @mvdnbrk. I'm sorry it took me this long to get to this. I've continued your work in a new PR here: #121. I'm looking for people who want to help me test here: #121 (comment) This will be included in the upcoming 1.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #71 (comment)
WIP