set based disk #76
Closed
set based disk #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
requested changes
Aug 16, 2020
|
Hi @driesvints . I have made some changes based your suggestions. Can you check please |
|
FYI: I haven't forgotten about this but I'm probably picking this up as soon as I get Blade UI Kit out of the door so that might still be a while. |
eballeste
reviewed
Nov 17, 2020
| @@ -15,7 +15,7 @@ public static function pathNotDefined(string $set): self | |||
|
|
|||
| public static function pathOrDiskNotDefined(string $set): self | |||
| { | |||
| return new static("The options for the \"$set\" set don't have a path or disk defined."); | |||
| return new static("The options for the \"$set\" need provide either a path or disk option."); | |||
There was a problem hiding this comment.
Suggested change
| return new static("The options for the \"$set\" need provide either a path or disk option."); | |
| return new static("The options for the \"$set\" need to be provided either a path or disk option."); |
|
Hi, was wondering if this may be merged sometime soon? Would love to use this package, but none of our icon assets are on local disk. |
Merged
|
Hey all, first of all I'm so sorry it took me this long to get to this. I took the liberty to send in an alternative implementation which should solve this: #111 I still want to thank you for this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made PR for this issue
#72