Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register optimize commands #253

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

erikgaal
Copy link
Contributor

@erikgaal erikgaal commented Oct 9, 2024

Newly introduced in Laravel 11.27, packages can now register the commands that should run during the optimize phase of deployment.

This PR adds the recommended steps for optimizing whenever it's available.

Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one remark.

optimize: 'icons:cache',
clear: 'icons:clear',
key: 'blade-icons'
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use named arguments so we don't have to drop older PHP versions?

Copy link
Contributor Author

@erikgaal erikgaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@driesvints driesvints merged commit 75a54a3 into blade-ui-kit:1.x Oct 17, 2024
14 checks passed
@driesvints
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants