Merge pull request #103 from owenvoke/bugfix/filter-svg

feat: ignore files without SVG extension
blade-ui-kit · Nov 3, 2020 · 309bb41 · 309bb41
2 parents 55d62d7 + 53633e9
commit 309bb41
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/src/Factory.php b/src/Factory.php
@@ -71,6 +71,10 @@ public function registerComponents(): void
     {
         foreach ($this->sets as $set) {
             foreach ($this->filesystem->allFiles($set['path']) as $file) {
+                if ($file->getExtension() !== 'svg') {
+                    continue;
+                }
+
                 $path = array_filter(explode('/', Str::after($file->getPath(), $set['path'])));
 
                 Blade::component(

diff --git a/tests/FactoryTest.php b/tests/FactoryTest.php
@@ -238,6 +238,17 @@ public function it_can_retrieve_an_icon_from_a_subdirectory()
         $this->assertSame('solid.camera', $icon->name());
     }
 
+    /** @test */
+    public function it_excludes_files_without_an_svg_extension()
+    {
+        $factory = $this->prepareSets();
+
+        $this->expectException(SvgNotFound::class);
+        $this->expectExceptionMessage('Svg by name "invalid-extension" from set "default" not found.');
+
+        $factory->svg('invalid-extension');
+    }
+
     /** @test */
     public function it_throws_an_exception_when_no_icon_is_found()
     {

diff --git a/tests/resources/svg/invalid-extension.txt b/tests/resources/svg/invalid-extension.txt