Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dur() function breaks when alongside text #798

Closed
blackpeasy opened this issue Jan 20, 2022 · 1 comment
Closed

dur() function breaks when alongside text #798

blackpeasy opened this issue Jan 20, 2022 · 1 comment
Assignees
Labels
bug Something isn't working.
Milestone

Comments

@blackpeasy
Copy link

What happened?

Any calculations that result in a duration seem to not be working, as soon as I type in text alongside it.

Table without id 
(Date[1]-Date[0]) as "duration", "text - "+(Date[1]-Date[0]) as "text + duration"
From ""
Where file.link = this.file.link

image

Table without id 
dur(Date[1]-Date[0]) as "duration", "text - "+dur(Date[1]-Date[0]) as "text + duration"
From ""
Where file.link = this.file.link

image

DQL

Table without id 
dur(Date[1]-Date[0]) as "duration", "text - "+dur(Date[1]-Date[0]) as "text + duration"
From ""
Where file.link = this.file.link

JS

No response

Dataview Version

0.4.22

Obsidian Version

0.13.19

OS

Windows

@blackpeasy blackpeasy added the bug Something isn't working. label Jan 20, 2022
@blacksmithgu blacksmithgu added this to the 0.4.23 milestone Jan 21, 2022
@blacksmithgu
Copy link
Owner

Adding durations to strings was broken due to a change in Luxon; I've fixed this for 0.4.23.

blacksmithgu pushed a commit that referenced this issue Jan 21, 2022
- Fix #798: Fix duration -> string implementation to use `minimalDuration`.
- Fix #743: Improve paragraph/span spacing in live preview.
- Fix #775: Add empty result warnings to task view.
- Fix #733: Add `?no-dataview` to disable dataview renders.
- Fix #792: Fix block link detection in tasks.
- Fix #799: Fix 'Task' -> 'Calendar' documentation typo.
- Fix #789: Fix date(tomorrow) typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

2 participants