Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute story option #181

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mute story option #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
141eb26
Added volume control in case of video
rohangetwyld7 Apr 29, 2024
2a96570
Added volume control in case of video
rohangetwyld7 Apr 29, 2024
09c19c1
Update story_view.dart
rohangetwyld7 Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/widgets/story_video.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,14 @@ class StoryVideo extends StatefulWidget {
final VideoLoader videoLoader;
final Widget? loadingWidget;
final Widget? errorWidget;
final double? volume;

StoryVideo(this.videoLoader, {
Key? key,
this.storyController,
this.loadingWidget,
this.errorWidget,
this.volume,
}) : super(key: key ?? UniqueKey());

static StoryVideo url(String url, {
Expand All @@ -59,13 +61,15 @@ class StoryVideo extends StatefulWidget {
Key? key,
Widget? loadingWidget,
Widget? errorWidget,
double? volume
}) {
return StoryVideo(
VideoLoader(url, requestHeaders: requestHeaders),
storyController: controller,
key: key,
loadingWidget: loadingWidget,
errorWidget: errorWidget,
volume : volume
);
}

Expand Down Expand Up @@ -104,6 +108,7 @@ class StoryVideoState extends State<StoryVideo> {
if (playbackState == PlaybackState.pause) {
playerController!.pause();
Copy link
Collaborator

@geekpius geekpius Jul 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mute means putting volume to 0. Your implementation is just setting volume. and not necessarily muting

} else {
playerController!.setVolume(widget.volume ?? 0.7);
playerController!.play();
}
});
Expand Down
2 changes: 2 additions & 0 deletions lib/widgets/story_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ class StoryItem {
Map<String, dynamic>? requestHeaders,
Widget? loadingWidget,
Widget? errorWidget,
double? volume,
}) {
return StoryItem(
Container(
Expand All @@ -242,6 +243,7 @@ class StoryItem {
requestHeaders: requestHeaders,
loadingWidget: loadingWidget,
errorWidget: errorWidget,
volume: volume
),
SafeArea(
child: Align(
Expand Down
48 changes: 40 additions & 8 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,38 +136,62 @@ packages:
url: "https://pub.dev"
source: hosted
version: "4.0.2"
leak_tracker:
dependency: transitive
description:
name: leak_tracker
sha256: "78eb209deea09858f5269f5a5b02be4049535f568c07b275096836f01ea323fa"
url: "https://pub.dev"
source: hosted
version: "10.0.0"
leak_tracker_flutter_testing:
dependency: transitive
description:
name: leak_tracker_flutter_testing
sha256: b46c5e37c19120a8a01918cfaf293547f47269f7cb4b0058f21531c2465d6ef0
url: "https://pub.dev"
source: hosted
version: "2.0.1"
leak_tracker_testing:
dependency: transitive
description:
name: leak_tracker_testing
sha256: a597f72a664dbd293f3bfc51f9ba69816f84dcd403cdac7066cb3f6003f3ab47
url: "https://pub.dev"
source: hosted
version: "2.0.1"
matcher:
dependency: transitive
description:
name: matcher
sha256: "1803e76e6653768d64ed8ff2e1e67bea3ad4b923eb5c56a295c3e634bad5960e"
sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb
url: "https://pub.dev"
source: hosted
version: "0.12.16"
version: "0.12.16+1"
material_color_utilities:
dependency: transitive
description:
name: material_color_utilities
sha256: "9528f2f296073ff54cb9fee677df673ace1218163c3bc7628093e7eed5203d41"
sha256: "0e0a020085b65b6083975e499759762399b4475f766c21668c4ecca34ea74e5a"
url: "https://pub.dev"
source: hosted
version: "0.5.0"
version: "0.8.0"
meta:
dependency: transitive
description:
name: meta
sha256: a6e590c838b18133bb482a2745ad77c5bb7715fb0451209e1a7567d416678b8e
sha256: d584fa6707a52763a52446f02cc621b077888fb63b93bbcb1143a7be5a0c0c04
url: "https://pub.dev"
source: hosted
version: "1.10.0"
version: "1.11.0"
path:
dependency: transitive
description:
name: path
sha256: "8829d8a55c13fc0e37127c29fedf290c102f4e40ae94ada574091fe0ff96c917"
sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af"
url: "https://pub.dev"
source: hosted
version: "1.8.3"
version: "1.9.0"
path_provider:
dependency: transitive
description:
Expand Down Expand Up @@ -389,6 +413,14 @@ packages:
url: "https://pub.dev"
source: hosted
version: "2.1.3"
vm_service:
dependency: transitive
description:
name: vm_service
sha256: b3d56ff4341b8f182b96aceb2fa20e3dcb336b9f867bc0eafc0de10f1048e957
url: "https://pub.dev"
source: hosted
version: "13.0.0"
web:
dependency: transitive
description:
Expand Down