Keep code location creation code only where its needed and some maintainability refactoring #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ainability refactoring
andrian-sevastyanov
requested review from
dterrybd,
gopannabd,
shantyk and
devmehtabd
| @@ -101,13 +94,4 @@ private boolean isBlackDuckVersionValid() { | |||
| Optional<BlackDuckVersion> blackDuckVersion = blackDuckRunData.getBlackDuckServerVersion(); | |||
| return blackDuckVersion.isPresent() && blackDuckVersion.get().isAtLeast(MIN_BLACK_DUCK_VERSION); | |||
| } | |||
|
|
|||
| private String createContainerScanCodeLocationName() { | |||
There was a problem hiding this comment.
Moved this out of abstract class to the specific class where it's used: PreScassContainerScanStepRunner.
This will make it more likely that we remove unused code once pre-SCASS stuff starts going away.
dterrybd
approved these changes
Feb 7, 2025
devmehtabd
approved these changes
Feb 13, 2025
andrian-sevastyanov
deleted the
refactor/andrians/scass-binary-container
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep code location creation code only where its needed and some maintainability refactoring based on sonar feedback.
Sonar scan on which some of this is based: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&sinceLeakPeriod=true&branch=origin%2Ffeature%2Fscass-binary-container&id=com.blackduck.integration%3Adetect