-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return a Unique Exit Code for Out of Memory Incidents #1339
Draft
zahidblackduck
wants to merge
6
commits into
master
Choose a base branch
from
dev/zahidblackduck/IDETECT-3872-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6b6b4b8
exit code due to out of memory update
zahidblackduck 8fa5fb6
winning exit code method update
zahidblackduck db09734
add priority field in exit code, update winning exit code method
zahidblackduck 7fe206b
unused imports removed from files, cleanup
zahidblackduck 435951a
refactor out of memory check in separate function
zahidblackduck d7cfc8a
update winning exit code logic. test exit code and priority uniqueness
zahidblackduck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/test/java/com/blackduck/integration/detect/configuration/ExitCodeTypeTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.blackduck.integration.detect.configuration; | ||
|
||
import com.blackduck.integration.detect.configuration.enumeration.ExitCodeType; | ||
import org.junit.jupiter.api.Test; | ||
import java.util.HashSet; | ||
import java.util.Set; | ||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
class ExitCodeTypeTest { | ||
|
||
@Test | ||
void testUniquePriorities() { | ||
Set<Double> priorities = new HashSet<>(); | ||
for (ExitCodeType exitCode : ExitCodeType.values()) { | ||
assertTrue(priorities.add(exitCode.getPriority()), | ||
"Duplicate priority found: " + exitCode.getPriority()); | ||
} | ||
} | ||
|
||
@Test | ||
void testUniqueExitCodes() { | ||
Set<Integer> exitCodes = new HashSet<>(); | ||
for (ExitCodeType exitCode : ExitCodeType.values()) { | ||
assertTrue(exitCodes.add(exitCode.getExitCode()), | ||
"Duplicate exit code found: " + exitCode.getExitCode()); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might just be me but I find this error checking a bit distracting in the overall flow of the performDetectors method. Perhaps consider refactoring these lines to a small method you can call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored this error checking into a function called
checkAndHandleOutOfMemoryIssue