Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yaml file in register command #3

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

blackchoey
Copy link
Owner

@blackchoey blackchoey commented Mar 29, 2024

  1. support yaml file in register command
  2. fix invalid api id and summary too long error when register the pet store spec
  3. Update help message and README with yml sample

@arpishahmsft
Copy link
Collaborator

Please test with

there are some open api spec examples here as well - OpenAPI-Specification/examples at main · OAI/OpenAPI-Specification (github.com)
OpenAPI-Specification/examples at main · OAI/OpenAPI-Specification
The OpenAPI Specification Repository. Contribute to OAI/OpenAPI-Specification development by creating an account on GitHub.

may be the petstore yml file and other examples from here OpenAPI-Specification/examples/v3.0 at main · OAI/OpenAPI-Specification (github.com)
OpenAPI-Specification/examples/v3.0 at main · OAI/OpenAPI-Specification
The OpenAPI Specification Repository. Contribute to OAI/OpenAPI-Specification development by creating an account on GitHub.

@arpishahmsft
Copy link
Collaborator

@blackchoey
Copy link
Owner Author

blackchoey commented Apr 2, 2024

@arpishahmsft I have tested the change with commands and specs in related bug.
For the specs you shared, I would like to merge this PR first and add test cases via another PR. So people can try the yaml support and verify bug fix earlier. I have a task to add automation test cases for the CLI commands.
Please let me know if you have other comments to the PR.

@blackchoey blackchoey requested a review from arpishahmsft as a code owner April 3, 2024 01:55
@blackchoey blackchoey merged commit 6596e67 into feature-2wk13 Apr 3, 2024
1 check passed
@blackchoey blackchoey deleted the api-register-yaml-support branch April 3, 2024 04:29
blackchoey added a commit that referenced this pull request Apr 29, 2024
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (#13)

* feat: remove --terms-of-service parameter (#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (#14)

* feat: fix command descriptions (#17)

* tests: add test cases for 'apic service' commands (#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19)

* fix: CLI errors (#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (#18)

* build: fix ci (#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (#28)

* doc: fix command samples (#30)

* doc: update changelog per feedback (#29)

* doc: remove extra spaces in register command help message (#34)

* doc: update api definition and metadata command samples (#36)
blackchoey added a commit that referenced this pull request Apr 29, 2024
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (#13)

* feat: remove --terms-of-service parameter (#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (#14)

* feat: fix command descriptions (#17)

* tests: add test cases for 'apic service' commands (#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19)

* fix: CLI errors (#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (#18)

* build: fix ci (#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (#28)

* doc: fix command samples (#30)

* doc: update changelog per feedback (#29)

* doc: remove extra spaces in register command help message (#34)

* doc: update api definition and metadata command samples (#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants