Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components/forms): set radio group 'aria-owns' to satisfy accessibility rules #671

Merged
merged 10 commits into from
Oct 21, 2022
Merged

fix(components/forms): set radio group 'aria-owns' to satisfy accessibility rules #671

merged 10 commits into from
Oct 21, 2022

Conversation

Blackbaud-SteveBrush
Copy link
Member

No description provided.

@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the title fix(components/forms): Set radio group 'aria-owns' to satisfy accessibility rules fix(components/forms): set radio group 'aria-owns' to satisfy accessibility rules Oct 12, 2022
@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 75dcd3a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 18 targets

Sent with 💌 from NxCloud.

@blackbaud-sky-build-user
Copy link
Collaborator

blackbaud-sky-build-user commented Oct 12, 2022 •
edited
Loading

Storybook preview

Component Storybooks:

Apps:

@Blackbaud-SteveBrush Blackbaud-SteveBrush marked this pull request as ready for review October 12, 2022 16:07
Blackbaud-PaulCrowder
Blackbaud-PaulCrowder reviewed Oct 20, 2022
View reviewed changes
libs/components/forms/src/lib/modules/radio/radio-group-id.service.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/radio-group.component.spec.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/radio-group.component.spec.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/radio-group.component.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/radio.component.spec.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/fixtures/radio.component.fixture.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/fixtures/radio.component.fixture.ts Outdated Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/radio-group-id.service.ts Show resolved Hide resolved
libs/components/forms/src/lib/modules/radio/fixtures/radio.component.fixture.html Show resolved Hide resolved
@Blackbaud-SteveBrush Blackbaud-SteveBrush merged commit 32f1e1e into main Oct 21, 2022
@Blackbaud-SteveBrush Blackbaud-SteveBrush deleted the a11y-radio-group branch October 21, 2022 16:10
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder Blackbaud-PaulCrowder approved these changes

@Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey Blackbaud-ErikaMcVey left review comments

@Blackbaud-TrevorBurch Blackbaud-TrevorBurch Blackbaud-TrevorBurch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Blackbaud-SteveBrush @blackbaud-sky-build-user @Blackbaud-PaulCrowder @Blackbaud-TrevorBurch @Blackbaud-ErikaMcVey