Skip to content

Commit

Permalink
Revert "Add popdown* functions to top bar"
Browse files Browse the repository at this point in the history
This reverts commit f985113.

Calling the `popdown*' functions causes the destructors of the views
to be called. As a result, the views lose their state.

Reverting this commit may use a little extra memory as the views are
kept in memory, but seems to have no other negative impact and
restores the behaviour known from 3.0.

Closes longturn#2329
  • Loading branch information
blabber committed Sep 7, 2024
1 parent dc32c27 commit 24e44b9
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions client/top_bar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@
#include "ratesdlg_g.h"
#include "tileset/sprite.h"
#include "top_bar.h"
#include "views/view_economics.h"
#include "views/view_map.h"
#include "views/view_nations.h"
#include "views/view_research.h"
#include "views/view_units.h"

Expand Down Expand Up @@ -449,11 +447,7 @@ void top_bar::addWidget(QWidget *fsw)
*/
void top_bar_show_map()
{
popdown_units_view();
popdown_city_dialog();
popdown_players_report();
popdown_economy_report();
popdown_science_report();
queen()->game_tab_widget->setCurrentIndex(0);
}

Expand Down

0 comments on commit 24e44b9

Please sign in to comment.