-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new etcd modules #12
Conversation
PR updated to the latest alpha version. |
Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
I think this is ready for review. We might want to wait for the stable release, but as of yesterday etcd 3.5 is in feature freeze. |
@bketelsen I would be very happy if this PR was reviewed and a new release was made. 🌹 |
Ping @bketelsen any opportunity to look at this pr? |
Even if it gets merged, I don't think it should be released until etcd 3.5 is tagged as well. |
Imho it would still be nice to get this merged so people can start playing with it at master/main. At any rate a sign of maintainer interest would be appreciated. |
Should also fix #14 |
You can play with my fork using replace. I'll update the PR to rc.0 later today. |
Merged but not tagged. Let me know if this works and a release is warranted |
Thanks @bketelsen ! I would wait with the release at least until the first RC (which should be out anytime). I'll keep sending PRs with the latest etcd version. |
This is a draft showing how the dependencies will look like, once the new etcd modules are released. This will resolve a lot of dependency issues in my opinion.