Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new etcd modules #12

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Use new etcd modules #12

merged 2 commits into from
Jun 3, 2021

Conversation

sagikazarmark
Copy link

This is a draft showing how the dependencies will look like, once the new etcd modules are released. This will resolve a lot of dependency issues in my opinion.

@sagikazarmark
Copy link
Author

PR updated to the latest alpha version.

Signed-off-by: Mark Sagi-Kazar <[email protected]>
Signed-off-by: Mark Sagi-Kazar <[email protected]>
@sagikazarmark sagikazarmark marked this pull request as ready for review May 18, 2021 11:50
@sagikazarmark
Copy link
Author

I think this is ready for review. We might want to wait for the stable release, but as of yesterday etcd 3.5 is in feature freeze.

@vvakame
Copy link

vvakame commented May 27, 2021

@bketelsen I would be very happy if this PR was reviewed and a new release was made. 🌹

@andig
Copy link

andig commented Jun 3, 2021

Ping @bketelsen any opportunity to look at this pr?

@sagikazarmark
Copy link
Author

Even if it gets merged, I don't think it should be released until etcd 3.5 is tagged as well.

@andig
Copy link

andig commented Jun 3, 2021

Imho it would still be nice to get this merged so people can start playing with it at master/main. At any rate a sign of maintainer interest would be appreciated.

@andig
Copy link

andig commented Jun 3, 2021

Should also fix #14

@sagikazarmark
Copy link
Author

You can play with my fork using replace. I'll update the PR to rc.0 later today.

@bketelsen bketelsen merged commit 501fab7 into bketelsen:master Jun 3, 2021
@bketelsen
Copy link
Owner

Merged but not tagged. Let me know if this works and a release is warranted

@sagikazarmark sagikazarmark deleted the etcd-modules branch June 3, 2021 22:48
@sagikazarmark
Copy link
Author

Thanks @bketelsen ! I would wait with the release at least until the first RC (which should be out anytime). I'll keep sending PRs with the latest etcd version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants