support esp-idf master, 4.1, and 4.0.1 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such as CONFIG_ESPTOOLPY_PORT. add only absolutely necessary options with reasons. the old one does not work at all. notable changes: * require SPI RAM, or PSRAM, because all the boards with camera come with PSRAM. the code probably does not work without SPI RAM. * use PSRAM when malloc(). without it, tasks will not start. * 4MB flash RAM is required now because the custom partition table does not fit into 2MB
esp-idf 3.x is still officially supported, but deprecated. from the point of developers' view, there is no reason to support 3.x. the lack of ESP_IDF_VERSION_* macros seriously hurts portability. replace "tcpip_adapter.h", which is deprecated in v4.1, with "esp_netif.h". remove many trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will support
esp-idfmaster, 4.1, and 4.0.1. tested withesp32-camfrom AI Thinker. notably, thesdkconfig.defaultshad run-time problems. 3.x support was dropped. the PR includes a GitHub Actions workflow to build the code in matrix.