Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails < 6.2 #404

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Conversation

JuanitoFatas
Copy link
Contributor

@JuanitoFatas JuanitoFatas commented Jan 2, 2020

My rails application (blog) works with this patch.

@siegy22
Copy link
Contributor

siegy22 commented Feb 3, 2020

I don't know why this patch is needed. There's no rails release with version 6.1.x? So this "patch" as of today doesn't do anything 😄

Can you explain what your problem was, why you introduced this change?

@JuanitoFatas
Copy link
Contributor Author

Oh I am terribly sorry. I always run my personal project on Rails master, which is now 6.1.0.alpha. I understand if you do not want this patch now. Feel free to close this.

@siegy22
Copy link
Contributor

siegy22 commented Feb 3, 2020

Well this temporarily fixes it, but I'd rather just do gem.add_dependency "railties", ">= 3.2" (without a max version) so you won't run into any problems on future releases too..

Because when rails 6.1.0 will be released, they will most likely bump the version to 6.2.0.alpha on master, which would break this version constraint yet again.

@JuanitoFatas
Copy link
Contributor Author

I followed the convention from last time we bumped this: #370. I‘m up for the >= 3.2 approach 👍

Copy link
Collaborator

@cadwallion cadwallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants