Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifiy conditional branch #385

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

takakuda
Copy link
Contributor

@takakuda takakuda commented Apr 9, 2019

i think modifiy unless -> if easy to understand.
my english is weak...
i`m sorry!

@stale
Copy link

stale bot commented Jun 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 8, 2019
@cadwallion
Copy link
Collaborator

Thank you for your contribution! Merging this in.

@stale stale bot removed the wontfix label Jun 15, 2019
@cadwallion cadwallion merged commit 00e14aa into bkeepers:master Jun 15, 2019
@mferrier
Copy link

@cadwallion @takakuda I think this breaks dotenv in cli because present? doesn't exist in plain ruby.

y-yagi added a commit to y-yagi/dotenv that referenced this pull request Jun 24, 2019
…ons_change"

This reverts commit 00e14aa, reversing
changes made to f796d36.

Reason: The pure Ruby doesn't have `Array#present?`. So this cause
`NoMethodError` when using dotenv without Rails.

```
$ dotenv -t .env
Traceback (most recent call last):
	3: from /bin/dotenv:23:in `<main>'
	2: from /bin/dotenv:23:in `load'
	1: from /lib/ruby/gems/2.5.0/gems/dotenv-2.7.3/bin/dotenv:4:in `<top (required)>'
/lib/ruby/gems/2.5.0/gems/dotenv-2.7.3/lib/dotenv/cli.rb:25:in `run': undefined method `present?' for []:Array (NoMethodError)
Did you mean?  prepend
```
@takakuda
Copy link
Contributor Author

Thank you for reverting.
I will be careful from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants