Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the option parser #382

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Clean up the option parser #382

merged 2 commits into from
Mar 22, 2019

Conversation

cadwallion
Copy link
Collaborator

This removes the regular expression logic and splitting out of the parser_args vs exec_args in favor of using OptionParser.order! which will not complain about unknown flags because order will stop at the first unknown argument.

This is a dramatic improvement to the CLI code clarity.

Closes #381

Thanks to @bensherman for pairing up to better understand what was going on under the hood, and finding the .order! method.

/cc @walro

This removes the regular expression logic and splitting out of the 
parser_args vs exec_args in favor of using OptionParser.order! which 
will not complain about unknown flags because order will stop at the 
first unknown argument.

This is a dramatic improvement to the CLI code clarity.

Co-authored-by: Ben Sherman <[email protected]>
@cadwallion cadwallion merged commit 62c0686 into master Mar 22, 2019
@cadwallion cadwallion deleted the quotes branch March 22, 2019 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant