Adding support for creating templates from .env files. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Templates can be checked in and will show the environment variables used but wont show the values
|
Thank you for the submission, and apologies for being slow to review this! I'll get this reviewed today. :) |
|
Conceptually I like this. :) Let me put it through its paces this week to see if anything shakes out. I'm going to be cutting a patch-level version release today ahead of this since a feature like this will need a minor version bump. |
|
OK sounds good! Let me know if there is anything I can help with |
|
Would be nice to see this merged @cadwallion |
|
👋 @thomasfedb Sorry to only just now swing back to this. I'm happy to include this if you can fix the merge conflict in the CLI. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates can be checked in and will show the environment variables used but wont show the values
I love using this package while writing demos at Stripe. However every now and then I miss a variable in my README.md or a handcrafted .env.template.
This adds a flag to the cli so that you can point it at any .env file and safely create a template from it that doesn't include any of your keys. :)