Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards Compatible Dotenv::Environment #345

Merged

Conversation

jessedoyle
Copy link
Contributor

  • Commit 7f82f73 introduced a backwards-incompatible change in the current API with respect to Dotenv::Environment#intialize by changing the method signature.
  • Make the new parameter default to false to retain backwards compatibility.
  • Similar changes were made for Dotenv::Parser in backward compatible to v2.2 as parser #338.

SEE: #323
SEE: #338

* Commit 7f82f73 introduced a backwards-incompatible change with
  the current API with respect to `Dotenv::Environment#intialize`
  by changing the method signature.
* Make the new parameter default to false to retain backwards
  compatibility.
* Similar changes were made for `Dotenv::Parser` in bkeepers#338.

SEE: bkeepers#323
SEE: bkeepers#338
Copy link

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really important PR that should be merged and shipped 🚀 Thanks @jessedoyle 👍

@joelvh
Copy link
Contributor

joelvh commented Jun 21, 2018

@cadwallion have you given any thought to this release? I know it's broken many frameworks. Is there a specific need to cause the breaking change?

@cadwallion cadwallion self-assigned this Jun 21, 2018
@cadwallion
Copy link
Collaborator

Thank you for this, I'll get this into the release I'm cutting shortly.

@cadwallion cadwallion merged commit b7dc48e into bkeepers:master Jun 21, 2018
@jessedoyle jessedoyle deleted the backwards-compatible-environment branch June 21, 2018 22:47
@cadwallion
Copy link
Collaborator

This was included in version 2.5.0, released a few minutes ago.

@joelvh
Copy link
Contributor

joelvh commented Jun 21, 2018

Awesome... thanks @cadwallion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants