Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand variables correctly #181

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Conversation

sorah
Copy link
Contributor

@sorah sorah commented Apr 2, 2015

Previously this fails:

Variable.call("${FOO} \\${FOO} ${FOO}", "FOO" => "BAR") #=> "BAR BAR ${FOO}"

@sorah
Copy link
Contributor Author

sorah commented Apr 2, 2015

Oops

@sorah sorah force-pushed the expand-vars-correctly branch 2 times, most recently from ae52cf8 to da7fa8c Compare April 2, 2015 02:58
@sorah
Copy link
Contributor Author

sorah commented Apr 2, 2015

Now CI passes.

Previously this fails:

    Variable.call("${FOO} \\${FOO} ${FOO}", "FOO" => "BAR")
    #=> "BAR BAR ${FOO}"
@sorah sorah force-pushed the expand-vars-correctly branch from da7fa8c to 42354f9 Compare April 2, 2015 03:55
@bkeepers
Copy link
Owner

bkeepers commented Apr 3, 2015

⚡ awesome, thanks!

bkeepers added a commit that referenced this pull request Apr 3, 2015
@bkeepers bkeepers merged commit f2b55cd into bkeepers:master Apr 3, 2015
@sorah sorah deleted the expand-vars-correctly branch September 7, 2015 12:41
sheax0r pushed a commit to sheax0r/dotenv that referenced this pull request Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants