Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan backend: fix bug in input vertex binding #1854

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

rinthel
Copy link
Contributor

@rinthel rinthel commented Aug 12, 2019

related issue: #274 (comment)

  • If vertex streams does not have attributes that are required by the vertex shader, bind it with default setting on vertex stream 0, like the previous code does.
  • Additionally, check the texture's stencil aspect bit with vulkan format, not with bgfx format.

@rinthel rinthel mentioned this pull request Aug 12, 2019
@bkaradzic bkaradzic merged commit 6bd2284 into bkaradzic:master Aug 12, 2019
@rinthel rinthel deleted the vulkan-vertex-binding-fix branch August 13, 2019 01:14
@attilaz
Copy link
Contributor

attilaz commented Aug 13, 2019

I have tested and this fixed my issues. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants