feat: add reactivate subscription method #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braaar
approved these changes
Feb 7, 2024
src/calls/event/event.ts
Outdated
| .path(({ id }) => `/v2/event/subscription/${id}`) | ||
| .method('put') | ||
| .body(requestBody) | ||
| .parseJson(withRuntype(getSubscriptionResponseRt)) |
There was a problem hiding this comment.
I'm not sure it's a good idea to reuse this runtype. Are they defined in the documentation to be the exact same, or do they just happen to be identical?
There was a problem hiding this comment.
oh thank you for pointing out the runtype, I need to double check that!
delete-merged-branch
bot
deleted the
xillians/add-reactivate-subscription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the tripletex documentation for webhooks, it is possible for the subscription to get the status
DISABLED_TOO_MANY_ERRORS. this can be reactivated by sending a PUT request on the subscription by id. Adding areactivateSubscriptionallows for this put request.documentation: https://developer.tripletex.no/docs/documentation/webhooks/
swagger: https://tripletex.no/v2-docs/#/event%2Fsubscription/EventSubscription_put