Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip channel when calling semver.satisfies to allow custom channels #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Strip channel when calling semver.satisfies to allow custom channels #24

wants to merge 2 commits into from

Conversation

biw
Copy link
Owner

@biw biw commented Mar 17, 2021

The semver packages doesn't seem to have any problems dealing with custom channels when calling gt:

> semver.gt('v0.14.1-canary', 'v0.14.0-canary')
true

But satisfies doesn't seem to support them:

> semver.satisfies('v0.14.1-canary', '>=v0.14.0-canary')
false

As a result, nuts always returns HTTP 204 for URLs like:

curl "http://nuts-canary.itch.ovh/update/darwin_x64/0.14.0-canary"

This patch strips the channel before calling semver.satisfies, which fixes the issue for us.

From GitbookIO/nuts#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biw @fasterthanlime