Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add escaping for bad platform string. #10

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Add escaping for bad platform string. #10

merged 3 commits into from
Mar 17, 2021

Conversation

biw
Copy link
Owner

@biw biw commented Mar 17, 2021

Mitigates XSS on bad download URLs such as https://YOUR.NUTS.URL/download/version/2.0.0/%3Cimg%20src=x%20onerror=alert(1)%3E
and https://YOUR.NUTS.URL/download/channel/alpha/%3Cimg%20src=x%20onerror=alert(1)%3E

I don't see anywhere I could just insert a test for this in the existing suite.

From GitbookIO/nuts#138

@biw biw merged commit 2a7ae8a into main Mar 17, 2021
@biw biw deleted the flohdot/master branch March 17, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biw @flohdot