Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM-888 Optimize secret fetching #31

Merged
merged 2 commits into from
Nov 3, 2023
Merged

SM-888 Optimize secret fetching #31

merged 2 commits into from
Nov 3, 2023

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Oct 25, 2023 •
edited
Loading

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This optimizes secret fetching by using the new /get-by-ids endpoint introduced in bitwarden/server#3134.

A successful run can be found here.

An intentionally failed run where an incorrect secret ID was entered can be found here.

Code changes

  • src/main.ts: Use get-by-ids
  • package*.json: Update @bitwarden/sdk-napi to 0.3.1
  • The remaining files were changed as a result of running npm run all

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – f860c06a-1a72-44db-ad05-d93945f4d0e1

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Use_Of_Hardcoded_Password /dist/node_modules/@bitwarden/sdk-napi/dist/bitwarden_client/schemas.js: 116 Attack Vector
LOW Use_Of_Hardcoded_Password /dist/node_modules/@bitwarden/sdk-napi/dist/bitwarden_client/schemas.js: 89 Attack Vector

Thomas-Avery
Thomas-Avery approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@tangowithfoxtrot tangowithfoxtrot merged commit ab0eaa7 into master Nov 3, 2023
7 of 9 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the SM-888-optimize-secret-fetching branch November 3, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas-Avery Thomas-Avery Thomas-Avery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tangowithfoxtrot @bitwarden-bot @Thomas-Avery