Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4252] Change attachment Size to be represented as a string #3335

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 9, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

We use JsonNumberHandling.WriteAsString) for Size in AttachmentResponse, unfortunately this isn't understood by the Open API generation we use and the generated rust code attempts to cast int to string which is an invalid operation.

Changes it to be an actual string in code, which should functionality be equivalent to existing behavior.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton requested a review from a team as a code owner October 9, 2023 08:39
@Hinton Hinton requested a review from gbubemismith October 9, 2023 08:39
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details27296972-604f-4228-96d1-862e1b4e80c3

No New Or Fixed Issues Found

@Hinton Hinton merged commit 18b4313 into master Oct 23, 2023
@Hinton Hinton deleted the ps/PM-4252 branch October 23, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants