-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform/pm 2535/upgrade to azure messaging servicebus #3102
Platform/pm 2535/upgrade to azure messaging servicebus #3102
Conversation
Remove Microsoft.Azure.ServiceBus
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been interested in seeing this change so this is great! Couple questions.
_topicClient = new TopicClient(globalSettings.ServiceBus.ConnectionString, | ||
globalSettings.ServiceBus.ApplicationCacheTopicName); | ||
_serviceBusClient = new ServiceBusClient(globalSettings.ServiceBus.ConnectionString); | ||
_topicMessageSender = new ServiceBusClient(globalSettings.ServiceBus.ConnectionString).CreateSender(globalSettings.ServiceBus.ApplicationCacheTopicName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is it safe to call CreateSender
in the constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the recommended practice: https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-performance-improvements?tabs=net-standard-sdk-2#reusing-factories-and-clients
…grade-to-azure-messaging-servicebus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only lock file updates. This is gonna help a ton of PRs though!
Type of change
Objective
Dependency update of Microsoft.Azure.ServiceBus to Azure.Messaging.ServiceBus.
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)