[PS-2363] fix bumping AccountRevisionDate when creating and updating ciphers
#2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
AccountRevisionDate when creating and updating ciphersAccountRevisionDate when creating and updating ciphers
justindbaur
requested changes
Feb 1, 2023
src/Infrastructure.EntityFramework/Repositories/CipherRepository.cs
Outdated
Show resolved
Hide resolved
src/Infrastructure.EntityFramework/Repositories/CipherRepository.cs
Outdated
Show resolved
Hide resolved
src/Infrastructure.EntityFramework/Repositories/CipherRepository.cs
Outdated
Show resolved
Hide resolved
M1cha
force-pushed
the
bump-account-rev
branch
from
5929a5f to
41d22e0
Compare
When the user is not part of an organization, `UserBumpAccountRevisionDateByCipherIdQuery` doesn't work. In that case we have to use `UserBumpAccountRevisionDateAsync` instead. This was already done by most parts of the code but a few more were missing. Fixes bitwarden#2615
M1cha
force-pushed
the
bump-account-rev
branch
from
41d22e0 to
b8b5bc9
Compare
|
@justindbaur Thanks for the review. I've addressed all of your suggestions. |
justindbaur
approved these changes
Feb 2, 2023
M1cha
added a commit
to M1cha/homeserver
that referenced
this pull request
Dec 2, 2023
My sync issues got fixed: bitwarden/server#2634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user is not part of an organization,
UserBumpAccountRevisionDateByCipherIdQuerydoesn't work. In that case we have to useUserBumpAccountRevisionDateAsyncinstead.This was already done by most parts of the code but a few more were missing.
Type of change
Objective
Fixes #2615