Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jwt parsing to use URL_SAFE_NO_PAD #450

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 19, 2023

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

JWT should be url encoded and never use padding.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1067d35) 45.21% compared to head (3b69483) 45.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   45.21%   45.21%           
=======================================
  Files         153      153           
  Lines        6918     6918           
=======================================
  Hits         3128     3128           
  Misses       3790     3790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hinton Hinton requested a review from MGibson1 January 4, 2024 10:04
Copy link
Member

@MGibson1 MGibson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default, right?

@Hinton
Copy link
Member Author

Hinton commented Jan 4, 2024

This follows the JWT spec, and how we encode our tokens.

@Hinton Hinton merged commit 816799d into main Jan 5, 2024
42 checks passed
@Hinton Hinton deleted the ps/jwt-url-encode branch January 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants