Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version bump workflow on call #426

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

vgrassia
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

This PR updates the checkout step to always be master. This limits the use of the workflow to only bump the version on master, but we shouldn't be using it on any other branch anyways. This was needed because when the workflow was called from another repository it was checking out the wrong repository.

Code changes

  • .github/workflows/version-bump.yml: Force checkout step to use master and create PR for merging into master.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vgrassia vgrassia self-assigned this Dec 12, 2023
@vgrassia vgrassia requested a review from a team as a code owner December 12, 2023 16:48
@vgrassia vgrassia enabled auto-merge (squash) December 12, 2023 16:50
@vgrassia vgrassia merged commit 33c8612 into master Dec 12, 2023
39 of 40 checks passed
@vgrassia vgrassia deleted the fix-version-bump-workflow-call branch December 12, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants