Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract JWT to it's own file #317

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Extract JWT to it's own file #317

merged 2 commits into from
Nov 2, 2023

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 2, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Move JWT handling from utils to auth. Also improve documentation and use FromStr instead of a custom function.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

@Hinton Hinton requested a review from dani-garcia November 2, 2023 15:07
@Hinton Hinton requested a review from dani-garcia November 2, 2023 16:40
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – 2d655d8e-f509-4be9-8e09-ef0af1db1e4b

No New Or Fixed Issues Found

@Hinton Hinton merged commit eefc58b into master Nov 2, 2023
44 checks passed
@Hinton Hinton deleted the ps/jwt branch November 2, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-garcia dani-garcia dani-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hinton @bitwarden-bot @dani-garcia