Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-18118: Updated update master password screen #1340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ezimet-livefront
Copy link
Collaborator

@ezimet-livefront ezimet-livefront commented Feb 10, 2025

🎟️ Tracking

PM-18118

📔 Objective

  • Moved “Log out” button from the right of the toolbar to the left

  • Removed “Submit” button from the bottom, and put “Save” button in top right of the toolbar

  • Updated “Master password” field label to “New master password”

  • Added password strength indicator below “New master password” field

  • Updated “Master password hint” field label to “New master password hint”

  • Addeded “(required)” to the Current master password field

  • Addeded “(required)” to the New master password field

  • Added “(required)” to the Re-type new master password field

Remove “A master password hint can help you remember your password if you forget it.” text and replace it with “Bitwarden cannot reset a lost or forgotten master password.”

Add clickable text “Learn about ways to prevent account lockout.” that when tapped, brings the user to the “Prevent account lockout” screen

📸 Screenshots

Before After
before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (4e894eb) to head (e25eb31).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   89.61%   89.64%   +0.02%     
==========================================
  Files         750      754       +4     
  Lines       47072    47375     +303     
==========================================
+ Hits        42185    42467     +282     
- Misses       4887     4908      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Logo
Checkmarx One – Scan Summary & Detailsa779573e-2e13-4f9e-8b00-2123150fb850

Great job, no security vulnerabilities found in this Pull Request

@ezimet-livefront ezimet-livefront changed the title PM-18118 updated update master password screen PM-18118: Updated update master password screen Feb 11, 2025
@ezimet-livefront ezimet-livefront marked this pull request as ready for review February 11, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant