Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14680] Change username entry to have an email address keyboard #1307

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

KatherineInCode
Copy link
Contributor

@KatherineInCode KatherineInCode commented Jan 28, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14680

Issue 1123

📔 Objective

Some users use Text Replacements in order to quickly fill out their email or common usernames in various forms. However, the Username field on the Add/Edit Login screen does not allow for doing Text Replacement, because autocorrect has been turned off on the field, and with the .default keyboard turning off autocomplete also turns off Text Replacement. This changes the keyboard for username fields to be an .emailAddress keyboard, which allows for Text Replacement while still keeping autocorrect off; note that this does not mark the field as an email address field, just the keyboard that shows up is one optimized for email entry. As a large number of usernames are themselves emails, this actually improves entry of those as well.

Further discussion on the Jira ticket.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode linked an issue Jan 28, 2025 that may be closed by this pull request
1 task
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7633b130-d9a0-46b5-b995-e8b41b64ce72

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (e7ea8b1) to head (c2f1ebe).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
- Coverage   89.46%   89.45%   -0.02%     
==========================================
  Files         742      743       +1     
  Lines       46637    46569      -68     
==========================================
- Hits        41726    41657      -69     
- Misses       4911     4912       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatherineInCode KatherineInCode marked this pull request as ready for review January 29, 2025 14:30
@KatherineInCode KatherineInCode merged commit b9ffb2d into main Jan 30, 2025
9 checks passed
@KatherineInCode KatherineInCode deleted the pm-14680/text-replacement branch January 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Built-in Text Replacement on Username Field
2 participants