PM-17006: Remove send custom deletion date option #1290
Conversation
matt-livefront
requested review from
fedemkr,
ezimet-livefront and
KatherineInCode
matt-livefront
requested review from
phil-livefront,
brant-livefront and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
==========================================
- Coverage 89.47% 89.45% -0.03%
==========================================
Files 733 733
Lines 46267 46224 -43
==========================================
- Hits 41399 41351 -48
- Misses 4868 4873 +5 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
| @@ -211,7 +211,7 @@ class AddEditSendItemProcessorTests: BitwardenTestCase { // swiftlint:disable:th | |||
| subject.state.name = "Name" | |||
| subject.state.type = .text | |||
| subject.state.text = "Text" | |||
| subject.state.deletionDate = .custom | |||
| subject.state.deletionDate = .custom(Date(year: 2023, month: 11, day: 5)) | |||
There was a problem hiding this comment.
❓Could we just create a constant for this deletion date, since they are all same?
| @@ -263,7 +263,7 @@ class AddEditSendItemViewTests: BitwardenTestCase { // swiftlint:disable:this ty | |||
| processor.state.fileName = "example_file.txt" | |||
| processor.state.fileData = Data("example".utf8) | |||
| processor.state.isHideTextByDefaultOn = true | |||
| processor.state.deletionDate = .custom | |||
| processor.state.deletionDate = .custom(Date(year: 2023, month: 11, day: 5, hour: 9, minute: 41)) | |||
There was a problem hiding this comment.
❓ same with this date, could we just create one, and reuse?
| case .edit: | ||
| [.oneHour, .oneDay, .twoDays, .threeDays, .sevenDays, .thirtyDays, .custom(customDeletionDate)] | ||
| } |
There was a problem hiding this comment.
Wouldn't custom option be available only if the send is configured in such way? Lmk if I'm wrong but I think that as it's here the user could just create a send with 1 hour deletion date and then edit it to a custom one.
There was a problem hiding this comment.
The custom option in edit mode is slightly different than before. Previously, you could select custom and then use the calendar to change the date to anything. Custom now just shows the fixed date in the menu. This makes it so:
- If you previously had a custom deletion date, that would still be preserved.
- We don't have to do date math - meaning if you choose 3 days, the data model only stores the calculated date of 3 days from today as the deleted date. So when you go to edit that send, we don't need to back calculate that you choose 3 days and instead can show the deletion date as the fixed custom option in the menu.
Like this:
There was a problem hiding this comment.
Oh missed that, thanks for explaining love it 🚀
matt-livefront
deleted the
matt/PM-17006-remove-send-custom-deletion-date
branch
🎟️ Tracking
PM-17006
📔 Objective
Removes the custom deletion date option from sends.
📸 Screenshots
New send:
Edit send:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes