Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extension Persistence Deep Dive #555

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Mar 3, 2025

📔 Objective

As more teams are starting to use the ViewCacheService for persisting extension data, I had some feedback that it would be good to have some documentation on the framework provided by Platform to do this.

This is my initial attempt at adding documentation. I'm open to any additions or clarifications, including moving it to a different area of the docs.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2025

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c339c7b
Status: ✅  Deploy successful!
Preview URL: https://9a27e7b6.contributing-docs.pages.dev
Branch Preview URL: https://add-persistence-deep-diave.contributing-docs.pages.dev

View logs

Copy link

github-actions bot commented Mar 3, 2025

Logo
Checkmarx One – Scan Summary & Details045f2b32-a051-4f29-928c-aca62460325b

Great job, no security vulnerabilities found in this Pull Request

@trmartin4
Copy link
Member Author

trmartin4 commented Mar 3, 2025

@willmartian @justindbaur I added you before I opened this up for wider review, and I want to make sure that I'm not wildly off base with the recommended usage.

Here is the new page.

@trmartin4 trmartin4 marked this pull request as ready for review March 8, 2025 02:27
@trmartin4 trmartin4 requested a review from a team as a code owner March 8, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant