Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security foundations section #487

Merged
merged 30 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
648221f
feat: add new security section
coroiu Nov 22, 2024
585c402
feat: port definitions
coroiu Nov 22, 2024
bf8369d
feat: add first principle
coroiu Nov 22, 2024
e65f223
feat: add second principle
coroiu Nov 25, 2024
cebbeb3
feat: add third principle
coroiu Nov 25, 2024
40a8bb7
feat: add note about TEEs to P03
coroiu Nov 25, 2024
6e650d7
chore: change protection > security
coroiu Nov 25, 2024
bcd9467
feat: add forth principle
coroiu Nov 25, 2024
8da13ec
feat: add fifth principle
coroiu Nov 25, 2024
4c755bb
feat: add fifth principle
coroiu Nov 25, 2024
e958797
feat: add an overview page
coroiu Nov 25, 2024
5d8a121
fix: remove repetition
coroiu Nov 25, 2024
3247efe
chore: rename file to match content
coroiu Nov 25, 2024
f9e585d
refactor: use hyphen in title
coroiu Nov 25, 2024
425f808
fix: links
coroiu Nov 25, 2024
e4f44ea
refactor: remove any after comment
coroiu Nov 25, 2024
b4a8c8d
feat: add current version of requirements
coroiu Nov 26, 2024
0222f3f
feat: add introduction to requirement structure
coroiu Nov 26, 2024
663b464
feat: add Client definition
coroiu Dec 10, 2024
aaca302
fix: tweak user definition
coroiu Dec 10, 2024
0373e12
feat: add technical consideration section to P01
coroiu Dec 10, 2024
528330f
fix: clarify which data locking protects
coroiu Dec 10, 2024
d5548f7
fix: typo
coroiu Dec 10, 2024
563e3a7
fix: change `linger` to `not present in memory`
coroiu Jan 9, 2025
83f0d56
fix: re-define sharing to match EA, previous definition of sharing isโ€ฆ
coroiu Jan 9, 2025
8eceee3
fix: font-weight
coroiu Jan 22, 2025
952a43c
feat: add token protected in transit req
coroiu Jan 22, 2025
7de826f
feat: change AT.2 to `must`
coroiu Jan 22, 2025
43c1e0e
chore: move security under architecture
coroiu Jan 27, 2025
43675f6
fix: various copy feedback
coroiu Jan 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: change AT.2 to must
coroiu committed Jan 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHubโ€™s verified signature. The key has expired.
commit 7de826f40d0e70b538bbdc895fae51795dbf231d
2 changes: 1 addition & 1 deletion docs/security/requirements.mdx
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ This section is still in its early stages and does not yet reflect current or fu

1. The authentication tokens **MUST** be protected at rest if the client provides a mechanism for
secure storage.
2. The authentication tokens **SHOULD** be protected in transit.
2. The authentication tokens **MUST** be protected in transit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. The authentication tokens **SHOULD** be protected in transit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! But why SHOULD and not MUST?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿค” I can't recall what I had in mind when suggesting SHOULD. I believe that it should be MUST, as you said. I've suggested that as another change.

## Secure channels (SC)