[PM-15201] Add info to clarify where to find email contents #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
eliykat
requested changes
Nov 25, 2024
There was a problem hiding this comment.
I found where this information currently is: https://contributing.bitwarden.com/getting-started/server/guide#mailcatcher . (I don't know why I couldn't find it last week!)
Can you please link to that section rather than repeating information. e.g. "See the [Setup Guide] for more information about Mailtrap."
Deploying contributing-docs with
|
| Latest commit: |
9d523bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09f491f6.contributing-docs.pages.dev |
| Branch Preview URL: | https://pm-15201-update-email-servic.contributing-docs.pages.dev |
eliykat
requested changes
Nov 25, 2024
jrmccannon
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15201
📔 Objective
Adding some more information to make it more explicit on how to find the email content locally.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes