Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0001-reactive-forms.md #465

Closed
wants to merge 1 commit into from
Closed

Update 0001-reactive-forms.md #465

wants to merge 1 commit into from

Conversation

trmartin4
Copy link
Member

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions github-actions bot added the adr label Oct 30, 2024
Copy link

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1da6b3
Status: ✅  Deploy successful!
Preview URL: https://ea31fb79.contributing-docs.pages.dev
Branch Preview URL: https://adr-label-test.contributing-docs.pages.dev

View logs

@trmartin4 trmartin4 marked this pull request as ready for review October 30, 2024 22:32
@trmartin4 trmartin4 requested a review from a team as a code owner October 30, 2024 22:32
@trmartin4
Copy link
Member Author

Testing ADR automation. Please ignore.

@trmartin4 trmartin4 closed this Oct 30, 2024
@trmartin4 trmartin4 reopened this Nov 8, 2024
@trmartin4 trmartin4 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant