[PM-14818] Adjust instructions for running EF integration tests #457
+102
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
addisonbeck
force-pushed
the
ac/addison/pm-10863-ef-integration-tests
branch
from
224b67a to
8b5527f
Compare
Deploying contributing-docs with
|
| Latest commit: |
df4242d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1ca41f24.contributing-docs.pages.dev |
| Branch Preview URL: | https://ac-addison-pm-10863-ef-integ.contributing-docs.pages.dev |
addisonbeck
force-pushed
the
ac/addison/pm-10863-ef-integration-tests
branch
from
8b5527f to
05d0165
Compare
eliykat
reviewed
Oct 23, 2024
mzieniukbw
reviewed
Nov 4, 2024
vincentsalucci
changed the title
addisonbeck
force-pushed
the
ac/addison/pm-10863-ef-integration-tests
branch
from
05d0165 to
19ce5aa
Compare
|
I've merged in the changes from #480 so we can merge these as a complete package with links from one to the other. |
mzieniukbw
requested changes
Jan 20, 2025
Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Maciej Zieniuk <[email protected]>
addisonbeck
commented
Jan 21, 2025
mzieniukbw
previously approved these changes
Jan 21, 2025
rkac-bw
previously approved these changes
Jan 21, 2025
eliykat
requested changes
Jan 22, 2025
Co-authored-by: Thomas Rittson <[email protected]>
Co-authored-by: Thomas Rittson <[email protected]>
Co-authored-by: Thomas Rittson <[email protected]>
Co-authored-by: Thomas Rittson <[email protected]>
Co-authored-by: Thomas Rittson <[email protected]>
eliykat
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10863
📔 Objective
This commit adds up to date documentation for running entity framework integration tests for
server. It has a companion PR for adding some of the mentioned functionality in bitwarden/server#4912📸 Screenshots
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes