Added section on ownership of flags in environments #389
Conversation
|
No New Or Fixed Issues Found |
|
@withinfocus when looking at this section, I encountered this text that may no longer be best practice:
Is this still our recommendation? I believe we now recommend that we should delete from LD, right? |
docs/contributing/feature-flags.md
Outdated
| ::: | ||
|
|
||
| The process for updating flag values and the ownership of flag changes depends on the environment | ||
| and change as a flag proceeds through our cloud landscape. |
There was a problem hiding this comment.
⛏️ "cloud landscape" sounds beautiful but perhaps too whimsical for docs 😜
There was a problem hiding this comment.
Updated in 151b341 (#389) to be a bit less poetic.
docs/contributing/feature-flags.md
Outdated
| team. The Engineering Manager of the team is responsible for maintaining and updating flag values. | ||
|
|
||
| By default, flags should be **enabled** in the development environment as soon as the flag is | ||
| created. This allows the feature to be viewed and exercised by Product, Design, the development |
There was a problem hiding this comment.
⛏️ I don't consider product or design groups to be proper nouns.
There was a problem hiding this comment.
Fixed in 151b341 (#389).
docs/contributing/feature-flags.md
Outdated
|
|
||
| ### Production environments | ||
|
|
||
| In the production environments, the ownership of the flag values is shared between Product and |
There was a problem hiding this comment.
Fixed in 151b341 (#389).
Huh, I don't remember this language being so explicit. We archive flags, not delete them, so maybe that was more the intention. |
Deploying contributing-docs with
|
| Latest commit: |
151b341
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7eab7c60.contributing-docs.pages.dev |
| Branch Preview URL: | https://clarify-feature-flag-environ.contributing-docs.pages.dev |
I removed that language and instead referenced the archive process at the end of the "Unwinding a feature flag" section. |
|
I think Todd is out so I am gonna merge this. |
🎟️ Tracking
Feedback from team members on lack of understanding of feature flag ownership between environments
📔 Objective
As we become more mature in our flag usage and have a USDEV environment, I felt it would be helpful to clarify what the expectations are for flag usage in each environment.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes