Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-4161] Fix build command on README.md #207

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[PM-4161] Fix build command on README.md #207

merged 1 commit into from
Oct 2, 2023

Conversation

mateusabelli
Copy link
Contributor

Objective

This patch adds the missing run command (npm run build) to the Build step on the README.
Copying the command as is, results in the following error:

Unknown command: "build"                          
                                                  
Did you mean this?                                
    npm run build # run the "build" package script

To see a list of supported npm commands, run:
  npm help                                   

Process finished with exit code 1

@mateusabelli mateusabelli requested a review from a team as a code owner September 30, 2023 20:30
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-4161

@bitwarden-bot bitwarden-bot changed the title Fix build command on README.md [PM-4161] Fix build command on README.md Sep 30, 2023
Hinton
Hinton approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mateusabelli, it should indeed be run build.

@Hinton Hinton merged commit d00763b into bitwarden:master Oct 2, 2023
Hinton added a commit that referenced this pull request Oct 2, 2023
@Hinton
Merge branch 'master' of github.com:bitwarden/contributing-docs into …
8f1b733 
…ps/migrations

* 'master' of github.com:bitwarden/contributing-docs: (37 commits)
  chore(deps): update dependency cspell to v7.3.7 (#206)
  [PM-4161] Fix build command on README.md (#207)
  Fixed typo in csharp.md (#180)
  Update our EDD process documentation (#166)
  chore(deps): update actions/checkout action to v4.1.0 (#204)
  chore(deps): lock file maintenance (#205)
  fix(deps): update npm minor to v2.4.3 (#203)
  use dash when running self-hosted dotnet profile (#202)
  chore(deps): update actions/checkout action to v4 (#191)
  chore(deps): lock file maintenance (#201)
  chore(deps): update npm minor (#195)
  fix(deps): update dependency docusaurus-lunr-search to v3 (#200)
  setup_secrets: Pass `-clear` as switch (#194)
  Update KeyConnector docs for ARM Macs (#171)
  Lock file maintenance (#193)
  Update dependency cspell to v7.3.5 (#192)
  Update dependency ubuntu to v22 (#174)
  Update gh minor (#181)
  Feature flag documentation updates and mentions about new local override capabilities (#187)
  Update npm minor (#188)
  ...

# Conflicts:
#	custom-words.txt
#	docs/contributing/database-migrations/edd.mdx
#	docs/contributing/database-migrations/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
community-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateusabelli @bitwarden-bot @Hinton