Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6983] Disable hardware acceleration for bad GPUs #8427

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Mar 21, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Force hardware acceleration to be disabled for machines with AMD switchable graphics due to #8003.

This relies on https://www.electronjs.org/docs/latest/api/app#appgetgpuinfoinfotype, an alternative implementation could use deviceId but hopefully amdSwitchable is slightly more generic and catches more devices.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@Hinton Hinton requested a review from justindbaur March 21, 2024 16:24
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 26.28%. Comparing base (cd5dc09) to head (b1185fa).
Report is 4 commits behind head on main.

Files Patch % Lines
apps/desktop/src/main.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8427      +/-   ##
==========================================
- Coverage   26.34%   26.28%   -0.07%     
==========================================
  Files        2286     2287       +1     
  Lines       66938    67038     +100     
  Branches    12577    12597      +20     
==========================================
- Hits        17635    17619      -16     
- Misses      47930    48039     +109     
- Partials     1373     1380       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also hide the option to turn on hardware acceleration during these circumstances both in the menu bar and the in app setting?

@Hinton
Copy link
Member Author

Hinton commented Mar 22, 2024

@justindbaur we could. I just didn't want to spend the time exposing it in the renderer.

@Hinton Hinton merged commit f70639d into main Mar 22, 2024
37 checks passed
@Hinton Hinton deleted the ps/PM-6983 branch March 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants