Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6195] Refactor injection of services in browser services module #8405

Conversation

djsmith85
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

As part of the StateProvider work we are re-visiting the usage of shared services between the background and popup and removing all unnecessary services.

Code changes

  • Remove PasswordStrengthService from popup/services.module - fc7d8b2
    • No state needs to be shared between background and popup. Meaning it can be safely removed.
  • Remove ImportService from popup/services.module - fd87d37
    • Can be removed as the import.component is standalone and provides the importService. For the fileless LP import we also don't need the injector within the popup as it's provided via jslib.services.module.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@djsmith85 djsmith85 requested a review from a team March 20, 2024 16:23
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Mar 20, 2024
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Mar 20, 2024
@djsmith85 djsmith85 enabled auto-merge (squash) March 20, 2024 16:25
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.28%. Comparing base (7240285) to head (fd87d37).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8405   +/-   ##
=======================================
  Coverage   26.28%   26.28%           
=======================================
  Files        2281     2281           
  Lines       66847    66845    -2     
  Branches    12566    12566           
=======================================
  Hits        17571    17571           
+ Misses      47907    47905    -2     
  Partials     1369     1369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 merged commit e80ee2e into main Mar 21, 2024
28 checks passed
@djsmith85 djsmith85 deleted the tools/pm-6195/refactor-injection-of-services-in-browser-services-module branch March 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants